Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 666163004: [NaCl SDK] Remove sys/signal.h from newlib-extras (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove sys/signal.h from newlib-extras The toolchains now contain an up-to-date version of thie header to its not longer needed here. Committed: https://crrev.com/baccf37192694f13b8c3421e496849aadf6d6471 Cr-Commit-Position: refs/heads/master@{#300534}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -318 lines) Patch
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/libraries/third_party/newlib-extras/sys/signal.h View 1 chunk +0 lines, -317 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 2 months ago (2014-10-21 17:16:24 UTC) #2
binji
lgtm
6 years, 2 months ago (2014-10-21 17:22:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666163004/20001
6 years, 2 months ago (2014-10-21 18:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 19:19:46 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 19:20:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/baccf37192694f13b8c3421e496849aadf6d6471
Cr-Commit-Position: refs/heads/master@{#300534}

Powered by Google App Engine
This is Rietveld 408576698