Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 666163003: DevTools: [SSP] do not rebuild styles when sidebar pane is not showing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 this.sections = {}; 540 this.sections = {};
541 if (userCallback) 541 if (userCallback)
542 userCallback(); 542 userCallback();
543 return null; 543 return null;
544 } 544 }
545 return this._node; 545 return this._node;
546 }, 546 },
547 547
548 _styleSheetOrMediaQueryResultChanged: function() 548 _styleSheetOrMediaQueryResultChanged: function()
549 { 549 {
550 if (this._userOperation || this._isEditingStyle) 550 if (this._userOperation || this._isEditingStyle || !this.isShowing())
vsevik 2014/10/21 15:32:32 Shouldn't we schedule an update when shown?
551 return; 551 return;
552 552
553 this._rebuildUpdate(); 553 this._rebuildUpdate();
554 }, 554 },
555 555
556 _frameResized: function() 556 _frameResized: function()
557 { 557 {
558 /** 558 /**
559 * @this {WebInspector.StylesSidebarPane} 559 * @this {WebInspector.StylesSidebarPane}
560 */ 560 */
(...skipping 3040 matching lines...) Expand 10 before | Expand all | Expand 10 after
3601 if (userEnteredText && (userEnteredText === userEnteredText.toUpperCase( ))) { 3601 if (userEnteredText && (userEnteredText === userEnteredText.toUpperCase( ))) {
3602 for (var i = 0; i < results.length; ++i) 3602 for (var i = 0; i < results.length; ++i)
3603 results[i] = results[i].toUpperCase(); 3603 results[i] = results[i].toUpperCase();
3604 } 3604 }
3605 var selectedIndex = this._cssCompletions.mostUsedOf(results); 3605 var selectedIndex = this._cssCompletions.mostUsedOf(results);
3606 completionsReadyCallback(results, selectedIndex); 3606 completionsReadyCallback(results, selectedIndex);
3607 }, 3607 },
3608 3608
3609 __proto__: WebInspector.TextPrompt.prototype 3609 __proto__: WebInspector.TextPrompt.prototype
3610 } 3610 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698