Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666163003: DevTools: [SSP] do not rebuild styles when sidebar pane is not showing (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] do not rebuild styles when sidebar pane is not showing BUG=425523 R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184162

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
lushnikov
6 years, 2 months ago (2014-10-21 13:35:45 UTC) #1
vsevik
https://codereview.chromium.org/666163003/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/666163003/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode550 Source/devtools/front_end/elements/StylesSidebarPane.js:550: if (this._userOperation || this._isEditingStyle || !this.isShowing()) Shouldn't we schedule ...
6 years, 2 months ago (2014-10-21 15:32:32 UTC) #2
vsevik
lgtm, but what about other types of events? attributeChanged, frameResized?
6 years, 2 months ago (2014-10-21 15:57:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666163003/1
6 years, 2 months ago (2014-10-22 06:57:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/30344)
6 years, 2 months ago (2014-10-22 07:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666163003/1
6 years, 2 months ago (2014-10-22 09:47:40 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 10:52:02 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184162

Powered by Google App Engine
This is Rietveld 408576698