Move XMLHttpRequest related files to core/xmlhttprequest.

Move XMLHttpRequest related files to core/xmlhttprequest.

XMLHttpRequest is not related to other core/xml files (such as XPath,
XSLTProcessor and so on), so move files to a new directory.

Add core/xmlhttprequest/OWNERS.
This CL does not change the behavior.

BUG=426816
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184622

[yhirano, 2014-10-24 08:05:14]

yhirano@chromium.org changed reviewers:
+ kouhei@chromium.org

[yhirano, 2014-10-24 08:05:15]

PTAL
Should I create a thread on blink-dev?

I could not remove inspector dependency on core/xml, so I give up bringing
classes to modules for now.

presubmit complains because XMLHttpRequest::State enum values violate the blink
style. I will ignore the errors.

[sof, 2014-10-24 08:32:44]

On 2014/10/24 08:05:15, yhirano wrote:
> PTAL
> Should I create a thread on blink-dev?
> 
> I could not remove inspector dependency on core/xml, so I give up bringing
> classes to modules for now.
> 

But you think it is feasible (within reason)?

[yhirano, 2014-10-24 08:46:21]

On 2014/10/24 08:32:44, sof wrote:
> On 2014/10/24 08:05:15, yhirano wrote:
> > PTAL
> > Should I create a thread on blink-dev?
> > 
> > I could not remove inspector dependency on core/xml, so I give up bringing
> > classes to modules for now.
> > 
> 
> But you think it is feasible (within reason)?

Because few classes depend on XHR related classes (as this CL shows), I would
like to move them to modules if possible.

[haraken, 2014-10-24 08:55:55]

On 2014/10/24 08:46:21, yhirano wrote:
> On 2014/10/24 08:32:44, sof wrote:
> > On 2014/10/24 08:05:15, yhirano wrote:
> > > PTAL
> > > Should I create a thread on blink-dev?
> > > 
> > > I could not remove inspector dependency on core/xml, so I give up bringing
> > > classes to modules for now.
> > > 
> > 
> > But you think it is feasible (within reason)?
> 
> Because few classes depend on XHR related classes (as this CL shows), I would
> like to move them to modules if possible.

tasak@ is planning to do that.

I think you can create a blink-dev thread, or wait for tasak@ to start a
discussion about core-module reorganization (which will happen next week).

[sof, 2014-10-24 09:17:02]

On 2014/10/24 08:55:55, haraken wrote:
> On 2014/10/24 08:46:21, yhirano wrote:
> > On 2014/10/24 08:32:44, sof wrote:
> > > On 2014/10/24 08:05:15, yhirano wrote:
> > > > PTAL
> > > > Should I create a thread on blink-dev?
> > > > 
> > > > I could not remove inspector dependency on core/xml, so I give up
bringing
> > > > classes to modules for now.
> > > > 
> > > 
> > > But you think it is feasible (within reason)?
> > 
> > Because few classes depend on XHR related classes (as this CL shows), I
would
> > like to move them to modules if possible.
> 
> tasak@ is planning to do that.
> 
> I think you can create a blink-dev thread, or wait for tasak@ to start a
> discussion about core-module reorganization (which will happen next week).

Sounds good.

If the follow-on reorg is not too far away, then creating a temporary
core/xmlhttprequest/ home is not worth it. ?

[kouhei (in TOK), 2014-10-24 09:24:19]

> If the follow-on reorg is not too far away, then creating a temporary
> core/xmlhttprequest/ home is not worth it. ?

I'm supportive of creating core/xmlhttprequest temporarily for smooth
transition.

[sof, 2014-10-24 11:11:22]

https://codereview.chromium.org/666153003/diff/20001/Source/core/xmlhttpreque...
File Source/core/xmlhttprequest/OWNERS (right):

https://codereview.chromium.org/666153003/diff/20001/Source/core/xmlhttpreque...
Source/core/xmlhttprequest/OWNERS:2: sof@opera.com
sigbjornf@opera.com is the registered email.

[yhirano, 2014-10-24 13:05:38]

https://codereview.chromium.org/666153003/diff/20001/Source/core/xmlhttpreque...
File Source/core/xmlhttprequest/OWNERS (right):

https://codereview.chromium.org/666153003/diff/20001/Source/core/xmlhttpreque...
Source/core/xmlhttprequest/OWNERS:2: sof@opera.com
On 2014/10/24 11:11:22, sof wrote:
> mailto:sigbjornf@opera.com is the registered email.

I'm sorry. Fixed.

[kouhei (in TOK), 2014-10-27 01:32:16]

Changes lgtm. Please wait for approval from sof and tyoshino.

[yhirano, 2014-10-27 03:32:36]

yhirano@chromium.org changed reviewers:
+ haraken@chromium.org, sigbjornf@opera.com, tyoshino@chromium.org

[yhirano, 2014-10-27 03:32:36]

+tyoshino, sof and haraken.

I think this is worth doing because added OWNERS (tyoshino and me) will speed up
XHR related reviews.

[haraken, 2014-10-27 03:33:31]

On 2014/10/27 03:32:36, yhirano wrote:
> +tyoshino, sof and haraken.
> 
> I think this is worth doing because added OWNERS (tyoshino and me) will speed
up
> XHR related reviews.

LGTM

[tyoshino (SeeGerritForStatus), 2014-10-27 03:56:20]

lgtm

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
File Source/core/xmlhttprequest/XMLHttpRequest.cpp (left):

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
Source/core/xmlhttprequest/XMLHttpRequest.cpp:536: }
did this cause presubmit error?

[yhirano, 2014-10-27 03:58:13]

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
File Source/core/xmlhttprequest/XMLHttpRequest.cpp (left):

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
Source/core/xmlhttprequest/XMLHttpRequest.cpp:536: }
On 2014/10/27 03:56:20, tyoshino wrote:
> did this cause presubmit error?

It did, though I think it's a false-positive.

[tyoshino (SeeGerritForStatus), 2014-10-27 04:02:05]

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
File Source/core/xmlhttprequest/XMLHttpRequest.cpp (left):

https://codereview.chromium.org/666153003/diff/40001/Source/core/xmlhttpreque...
Source/core/xmlhttprequest/XMLHttpRequest.cpp:536: }
On 2014/10/27 03:58:13, yhirano wrote:
> On 2014/10/27 03:56:20, tyoshino wrote:
> > did this cause presubmit error?
> 
> It did, though I think it's a false-positive.

OK. I like this kind of use of braces for limiting variables' scope, but don't
care so much.

[yhirano, 2014-10-30 05:09:15]

sof: ping

[sof, 2014-10-30 06:11:51]

On 2014/10/30 05:09:15, yhirano wrote:
> sof: ping

lgtm as well

[yhirano, 2014-10-30 06:12:18]

On 2014/10/30 06:11:51, sof wrote:
> On 2014/10/30 05:09:15, yhirano wrote:
> > sof: ping
> 
> lgtm as well

Thanks!

[yhirano, 2014-10-30 06:12:23]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-10-30 06:12:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/666153003/60001

[commit-bot: I haz the power, 2014-10-30 07:34:43]

Committed patchset #4 (id:60001) as 184622