chrome/browser/extensions/extension_sync_bundle.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_bundle.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor_factory.h ('k') | chrome/browser/extensions/extension_sync_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_bundle.h

diff --git a/chrome/browser/extensions/extension_sync_bundle.h b/chrome/browser/extensions/extension_sync_bundle.h

index f9986ac3eedb68585a4184e2028579efa2402bcf..7e8eddaf250a5fa85f002bd3be19f50a8d6d62a7 100644

--- a/chrome/browser/extensions/extension_sync_bundle.h

+++ b/chrome/browser/extensions/extension_sync_bundle.h

@@ -32,7 +32,7 @@ class ExtensionSet;

class ExtensionSyncBundle : public SyncBundle {

public:

explicit ExtensionSyncBundle(ExtensionSyncService* extension_sync_service);

- virtual ~ExtensionSyncBundle();

+ ~ExtensionSyncBundle() override;

// Setup this bundle to be sync extension data.

void SetupSync(syncer::SyncChangeProcessor* sync_processor,

@@ -80,10 +80,10 @@ class ExtensionSyncBundle : public SyncBundle {

// Overrides for SyncBundle.

// Returns true if SetupSync has been called, false otherwise.

- virtual bool IsSyncing() const override;

+ bool IsSyncing() const override;

// Sync a newly-installed extension or change an existing one.

- virtual void SyncChangeIfNeeded(const Extension& extension) override;

+ void SyncChangeIfNeeded(const Extension& extension) override;

private:

// Add a synced extension.