chrome/browser/extensions/webstore_data_fetcher.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_data_fetcher.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/user_script_loader_unittest.cc ('k') | chrome/browser/extensions/webstore_inline_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_data_fetcher.h

diff --git a/chrome/browser/extensions/webstore_data_fetcher.h b/chrome/browser/extensions/webstore_data_fetcher.h

index a7abe312409db1b3e644ff3ad01ab239273fd6b7..d75b9999aef1fc3ad96dc9ba2afeb81b1d6ce3cd 100644

--- a/chrome/browser/extensions/webstore_data_fetcher.h

+++ b/chrome/browser/extensions/webstore_data_fetcher.h

@@ -34,7 +34,7 @@ class WebstoreDataFetcher : public base::SupportsWeakPtr<WebstoreDataFetcher>,

net::URLRequestContextGetter* request_context,

const GURL& referrer_url,

const std::string webstore_item_id);

- virtual ~WebstoreDataFetcher();

+ ~WebstoreDataFetcher() override;

void Start();

@@ -47,7 +47,7 @@ class WebstoreDataFetcher : public base::SupportsWeakPtr<WebstoreDataFetcher>,

void OnJsonParseFailure(const std::string& error);

// net::URLFetcherDelegate overrides:

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

WebstoreDataFetcherDelegate* delegate_;

net::URLRequestContextGetter* request_context_;

« no previous file with comments | « chrome/browser/extensions/user_script_loader_unittest.cc ('k') | chrome/browser/extensions/webstore_inline_installer.h » ('j') | no next file with comments »