Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
index b9a20bbc98cdaf02940d7baeb7dc49e38c597ea4..d835a12e9dc8bb65871b8ecdcb9e60806d748a33 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
@@ -140,29 +140,24 @@ class FakeExtensionGCMAppHandler : public ExtensionGCMAppHandler {
app_handler_count_drop_to_zero_(false) {
}
- virtual ~FakeExtensionGCMAppHandler() {
- }
+ ~FakeExtensionGCMAppHandler() override {}
- virtual void OnMessage(
- const std::string& app_id,
- const gcm::GCMClient::IncomingMessage& message) override {
- }
+ void OnMessage(const std::string& app_id,
+ const gcm::GCMClient::IncomingMessage& message) override {}
- virtual void OnMessagesDeleted(const std::string& app_id) override {
- }
+ void OnMessagesDeleted(const std::string& app_id) override {}
- virtual void OnSendError(
+ void OnSendError(
const std::string& app_id,
- const gcm::GCMClient::SendErrorDetails& send_error_details) override {
- }
+ const gcm::GCMClient::SendErrorDetails& send_error_details) override {}
- virtual void OnUnregisterCompleted(const std::string& app_id,
- gcm::GCMClient::Result result) override {
+ void OnUnregisterCompleted(const std::string& app_id,
+ gcm::GCMClient::Result result) override {
unregistration_result_ = result;
waiter_->SignalCompleted();
}
- virtual void RemoveAppHandler(const std::string& app_id) override{
+ void RemoveAppHandler(const std::string& app_id) override {
ExtensionGCMAppHandler::RemoveAppHandler(app_id);
if (!GetGCMDriver()->app_handlers().size())
app_handler_count_drop_to_zero_ = true;
« no previous file with comments | « chrome/browser/extensions/extension_gcm_app_handler.h ('k') | chrome/browser/extensions/extension_geolocation_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698