chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_indicator/system_indicator_manager.h ('k') | chrome/browser/extensions/api/system_indicator/system_indicator_manager_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

index ac56518f4390bdef3958e2cecc17fbfb271b5e2d..f358a95b90bd2e9168a4ef4ad5428cb26ccf3b97 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc

@@ -33,13 +33,13 @@ class ExtensionIndicatorIcon : public StatusIconObserver,

const ExtensionAction* action,

Profile* profile,

StatusTray* status_tray);

- virtual ~ExtensionIndicatorIcon();

+ ~ExtensionIndicatorIcon() override;

// StatusIconObserver implementation.

- virtual void OnStatusIconClicked() override;

+ void OnStatusIconClicked() override;

// ExtensionActionIconFactory::Observer implementation.

- virtual void OnIconUpdated() override;

+ void OnIconUpdated() override;

private:

ExtensionIndicatorIcon(const Extension* extension,