chrome/browser/extensions/extension_error_controller.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_error_controller.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui_browsertest.cc ('k') | chrome/browser/extensions/extension_error_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_error_controller.h

diff --git a/chrome/browser/extensions/extension_error_controller.h b/chrome/browser/extensions/extension_error_controller.h

index 26987d22c8cf3cda9ee5c462d5c95c29007e4712..06c061383f097759fa33ee3f39243785e129c679 100644

--- a/chrome/browser/extensions/extension_error_controller.h

+++ b/chrome/browser/extensions/extension_error_controller.h

@@ -32,12 +32,12 @@ class ExtensionErrorController : public ExtensionErrorUI::Delegate {

private:

// ExtensionErrorUI::Delegate implementation:

- virtual content::BrowserContext* GetContext() override;

- virtual const ExtensionSet& GetExternalExtensions() override;

- virtual const ExtensionSet& GetBlacklistedExtensions() override;

- virtual void OnAlertDetails() override;

- virtual void OnAlertAccept() override;

- virtual void OnAlertClosed() override;

+ content::BrowserContext* GetContext() override;

+ const ExtensionSet& GetExternalExtensions() override;

+ const ExtensionSet& GetBlacklistedExtensions() override;

+ void OnAlertDetails() override;

+ void OnAlertAccept() override;

+ void OnAlertClosed() override;

// Find any extensions that the user should be alerted about (like blacklisted

// extensions).