chrome/browser/extensions/api/idltest/idltest_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/idltest/idltest_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/idle/idle_manager_factory.h ('k') | chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/idltest/idltest_api.h

diff --git a/chrome/browser/extensions/api/idltest/idltest_api.h b/chrome/browser/extensions/api/idltest/idltest_api.h

index 19f6156c8049d3b11d25d5e11fcef90b173aa3ff..587664e310c560e60abe2b5a91e88bbc4d1cfb31 100644

--- a/chrome/browser/extensions/api/idltest/idltest_api.h

+++ b/chrome/browser/extensions/api/idltest/idltest_api.h

@@ -12,8 +12,8 @@ class IdltestSendArrayBufferFunction : public SyncExtensionFunction {

DECLARE_EXTENSION_FUNCTION("idltest.sendArrayBuffer", IDLTEST_SENDARRAYBUFFER)

protected:

- virtual ~IdltestSendArrayBufferFunction() {}

- virtual bool RunSync() override;

+ ~IdltestSendArrayBufferFunction() override {}

+ bool RunSync() override;

};

class IdltestSendArrayBufferViewFunction : public SyncExtensionFunction {

@@ -22,8 +22,8 @@ class IdltestSendArrayBufferViewFunction : public SyncExtensionFunction {

IDLTEST_SENDARRAYBUFFERVIEW)

protected:

- virtual ~IdltestSendArrayBufferViewFunction() {}

- virtual bool RunSync() override;

+ ~IdltestSendArrayBufferViewFunction() override {}

+ bool RunSync() override;

};

class IdltestGetArrayBufferFunction : public SyncExtensionFunction {

@@ -31,8 +31,8 @@ class IdltestGetArrayBufferFunction : public SyncExtensionFunction {

DECLARE_EXTENSION_FUNCTION("idltest.getArrayBuffer", IDLTEST_GETARRAYBUFFER)

protected:

- virtual ~IdltestGetArrayBufferFunction() {}

- virtual bool RunSync() override;

+ ~IdltestGetArrayBufferFunction() override {}

+ bool RunSync() override;

};

#endif // CHROME_BROWSER_EXTENSIONS_API_IDLTEST_IDLTEST_API_H_