Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6816)

Unified Diff: chrome/browser/extensions/extension_error_ui_default.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_error_ui_default.h
diff --git a/chrome/browser/extensions/extension_error_ui_default.h b/chrome/browser/extensions/extension_error_ui_default.h
index b080857e5e7113157b7b5f9c467055ed91c10a6e..d6b01d6fdd8681824d064358d149fef760467614 100644
--- a/chrome/browser/extensions/extension_error_ui_default.h
+++ b/chrome/browser/extensions/extension_error_ui_default.h
@@ -19,12 +19,12 @@ namespace extensions {
class ExtensionErrorUIDefault : public ExtensionErrorUI {
public:
explicit ExtensionErrorUIDefault(ExtensionErrorUI::Delegate* delegate);
- virtual ~ExtensionErrorUIDefault();
+ ~ExtensionErrorUIDefault() override;
// ExtensionErrorUI implementation:
- virtual bool ShowErrorInBubbleView() override;
- virtual void ShowExtensions() override;
- virtual void Close() override;
+ bool ShowErrorInBubbleView() override;
+ void ShowExtensions() override;
+ void Close() override;
private:
class ExtensionGlobalError : public GlobalErrorWithStandardBubble {
@@ -33,17 +33,17 @@ class ExtensionErrorUIDefault : public ExtensionErrorUI {
private:
// GlobalError methods.
- virtual bool HasMenuItem() override;
- virtual int MenuItemCommandID() override;
- virtual base::string16 MenuItemLabel() override;
- virtual void ExecuteMenuItem(Browser* browser) override;
- virtual base::string16 GetBubbleViewTitle() override;
- virtual std::vector<base::string16> GetBubbleViewMessages() override;
- virtual base::string16 GetBubbleViewAcceptButtonLabel() override;
- virtual base::string16 GetBubbleViewCancelButtonLabel() override;
- virtual void OnBubbleViewDidClose(Browser* browser) override;
- virtual void BubbleViewAcceptButtonPressed(Browser* browser) override;
- virtual void BubbleViewCancelButtonPressed(Browser* browser) override;
+ bool HasMenuItem() override;
+ int MenuItemCommandID() override;
+ base::string16 MenuItemLabel() override;
+ void ExecuteMenuItem(Browser* browser) override;
+ base::string16 GetBubbleViewTitle() override;
+ std::vector<base::string16> GetBubbleViewMessages() override;
+ base::string16 GetBubbleViewAcceptButtonLabel() override;
+ base::string16 GetBubbleViewCancelButtonLabel() override;
+ void OnBubbleViewDidClose(Browser* browser) override;
+ void BubbleViewAcceptButtonPressed(Browser* browser) override;
+ void BubbleViewCancelButtonPressed(Browser* browser) override;
// The ExtensionErrorUIDefault who owns us.
ExtensionErrorUIDefault* error_ui_;

Powered by Google App Engine
This is Rietveld 408576698