chrome/browser/extensions/extension_management.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_keybinding_registry.h ('k') | chrome/browser/extensions/extension_message_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management.h

diff --git a/chrome/browser/extensions/extension_management.h b/chrome/browser/extensions/extension_management.h

index 8727fd5f634db563c95629901550ff6096b278f8..879cffb910c77f6f77335e41ba86eb6adbf7aa5e 100644

--- a/chrome/browser/extensions/extension_management.h

+++ b/chrome/browser/extensions/extension_management.h

@@ -63,7 +63,7 @@ class ExtensionManagement : public KeyedService {

};

explicit ExtensionManagement(PrefService* pref_service);

- virtual ~ExtensionManagement();

+ ~ExtensionManagement() override;

void AddObserver(Observer* observer);

void RemoveObserver(Observer* observer);

@@ -168,14 +168,14 @@ class ExtensionManagementFactory : public BrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<ExtensionManagementFactory>;

ExtensionManagementFactory();

- virtual ~ExtensionManagementFactory();

+ ~ExtensionManagementFactory() override;

// BrowserContextKeyedServiceExtensionManagementFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* context) const override;

- virtual content::BrowserContext* GetBrowserContextToUse(

+ content::BrowserContext* GetBrowserContextToUse(

content::BrowserContext* context) const override;

- virtual void RegisterProfilePrefs(

+ void RegisterProfilePrefs(

user_prefs::PrefRegistrySyncable* registry) override;

DISALLOW_COPY_AND_ASSIGN(ExtensionManagementFactory);