chrome/browser/extensions/extension_action_manager.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_manager.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_manager.h

diff --git a/chrome/browser/extensions/extension_action_manager.h b/chrome/browser/extensions/extension_action_manager.h

index 6f602bd336ccf4d1f6f2c0d9dea165fc27f8d337..53451d593d7752f27523cbc14bd4744c5c7562b9 100644

--- a/chrome/browser/extensions/extension_action_manager.h

+++ b/chrome/browser/extensions/extension_action_manager.h

@@ -27,7 +27,7 @@ class ExtensionActionManager : public KeyedService,

public ExtensionRegistryObserver {

public:

explicit ExtensionActionManager(Profile* profile);

- virtual ~ExtensionActionManager();

+ ~ExtensionActionManager() override;

// Returns this profile's ExtensionActionManager. One instance is

// shared between a profile and its incognito version.

@@ -56,10 +56,9 @@ class ExtensionActionManager : public KeyedService,

private:

// Implement ExtensionRegistryObserver.

- virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason)

- override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

Profile* profile_;