Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/extensions/ntp_overridden_bubble_controller.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/ntp_overridden_bubble_controller.cc
diff --git a/chrome/browser/extensions/ntp_overridden_bubble_controller.cc b/chrome/browser/extensions/ntp_overridden_bubble_controller.cc
index 121d286ed50abe8e897f5c9c4f820ef58bafb103..bec4ed3c628957158975f14975519ec330d9a571 100644
--- a/chrome/browser/extensions/ntp_overridden_bubble_controller.cc
+++ b/chrome/browser/extensions/ntp_overridden_bubble_controller.cc
@@ -30,30 +30,27 @@ class NtpOverriddenBubbleDelegate
: public extensions::ExtensionMessageBubbleController::Delegate {
public:
NtpOverriddenBubbleDelegate(ExtensionService* service, Profile* profile);
- virtual ~NtpOverriddenBubbleDelegate();
+ ~NtpOverriddenBubbleDelegate() override;
// ExtensionMessageBubbleController::Delegate methods.
- virtual bool ShouldIncludeExtension(const std::string& extension_id) override;
- virtual void AcknowledgeExtension(
+ bool ShouldIncludeExtension(const std::string& extension_id) override;
+ void AcknowledgeExtension(
const std::string& extension_id,
- extensions::ExtensionMessageBubbleController::BubbleAction
- user_action) override;
- virtual void PerformAction(const extensions::ExtensionIdList& list) override;
- virtual base::string16 GetTitle() const override;
- virtual base::string16 GetMessageBody(
- bool anchored_to_browser_action) const override;
- virtual base::string16 GetOverflowText(
+ extensions::ExtensionMessageBubbleController::BubbleAction user_action)
+ override;
+ void PerformAction(const extensions::ExtensionIdList& list) override;
+ base::string16 GetTitle() const override;
+ base::string16 GetMessageBody(bool anchored_to_browser_action) const override;
+ base::string16 GetOverflowText(
const base::string16& overflow_count) const override;
- virtual GURL GetLearnMoreUrl() const override;
- virtual base::string16 GetActionButtonLabel() const override;
- virtual base::string16 GetDismissButtonLabel() const override;
- virtual bool ShouldShowExtensionList() const override;
- virtual void RestrictToSingleExtension(
- const std::string& extension_id) override;
- virtual void LogExtensionCount(size_t count) override;
- virtual void LogAction(
- extensions::ExtensionMessageBubbleController::BubbleAction
- action) override;
+ GURL GetLearnMoreUrl() const override;
+ base::string16 GetActionButtonLabel() const override;
+ base::string16 GetDismissButtonLabel() const override;
+ bool ShouldShowExtensionList() const override;
+ void RestrictToSingleExtension(const std::string& extension_id) override;
+ void LogExtensionCount(size_t count) override;
+ void LogAction(extensions::ExtensionMessageBubbleController::BubbleAction
+ action) override;
private:
// Our extension service. Weak, not owned by us.

Powered by Google App Engine
This is Rietveld 408576698