Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2306)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/copresence/copresence_api.h
diff --git a/chrome/browser/extensions/api/copresence/copresence_api.h b/chrome/browser/extensions/api/copresence/copresence_api.h
index 5776fd79d12654929cda55498774ca5d161d6f1b..79601328b5cf68a8b3f7c93f621680c230e3fe53 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api.h
+++ b/chrome/browser/extensions/api/copresence/copresence_api.h
@@ -28,10 +28,10 @@ class CopresenceService : public BrowserContextKeyedAPI,
public copresence::CopresenceDelegate {
public:
explicit CopresenceService(content::BrowserContext* context);
- virtual ~CopresenceService();
+ ~CopresenceService() override;
// BrowserContextKeyedAPI implementation.
- virtual void Shutdown() override;
+ void Shutdown() override;
// These accessors will always return an object (except during shutdown).
// If the object doesn't exist, they will create one first.
@@ -56,14 +56,13 @@ class CopresenceService : public BrowserContextKeyedAPI,
friend class BrowserContextKeyedAPIFactory<CopresenceService>;
// CopresenceDelegate implementation
- virtual void HandleMessages(
- const std::string& app_id,
- const std::string& subscription_id,
- const std::vector<copresence::Message>& message) override;
- virtual net::URLRequestContextGetter* GetRequestContext() const override;
- virtual const std::string GetPlatformVersionString() const override;
- virtual const std::string GetAPIKey() const override;
- virtual copresence::WhispernetClient* GetWhispernetClient() override;
+ void HandleMessages(const std::string& app_id,
+ const std::string& subscription_id,
+ const std::vector<copresence::Message>& message) override;
+ net::URLRequestContextGetter* GetRequestContext() const override;
+ const std::string GetPlatformVersionString() const override;
+ const std::string GetAPIKey() const override;
+ copresence::WhispernetClient* GetWhispernetClient() override;
// BrowserContextKeyedAPI implementation.
static const char* service_name() { return "CopresenceService"; }
@@ -89,8 +88,8 @@ class CopresenceExecuteFunction : public ChromeUIThreadExtensionFunction {
DECLARE_EXTENSION_FUNCTION("copresence.execute", COPRESENCE_EXECUTE);
protected:
- virtual ~CopresenceExecuteFunction() {}
- virtual ExtensionFunction::ResponseAction Run() override;
+ ~CopresenceExecuteFunction() override {}
+ ExtensionFunction::ResponseAction Run() override;
private:
void SendResult(copresence::CopresenceStatus status);
@@ -101,8 +100,8 @@ class CopresenceSetApiKeyFunction : public ChromeUIThreadExtensionFunction {
DECLARE_EXTENSION_FUNCTION("copresence.setApiKey", COPRESENCE_SETAPIKEY);
protected:
- virtual ~CopresenceSetApiKeyFunction() {}
- virtual ExtensionFunction::ResponseAction Run() override;
+ ~CopresenceSetApiKeyFunction() override {}
+ ExtensionFunction::ResponseAction Run() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698