chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h

diff --git a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h

index dfe80532736f8c2fb56bc1124ffc07673c041891..2233c59e6f841ad5d0a69e5d5fe18c1bce544c1d 100644

--- a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h

+++ b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h

@@ -13,20 +13,20 @@ class ChromeExtensionWebRequestEventRouterDelegate :

public extensions::WebRequestEventRouterDelegate {

public:

ChromeExtensionWebRequestEventRouterDelegate();

- virtual ~ChromeExtensionWebRequestEventRouterDelegate();

+ ~ChromeExtensionWebRequestEventRouterDelegate() override;

// WebRequestEventRouterDelegate implementation.

- virtual void ExtractExtraRequestDetails(

- net::URLRequest* request, base::DictionaryValue* out) override;

- virtual bool OnGetMatchingListenersImplCheck(

- int tab_id, int window_id, net::URLRequest* request) override;

- virtual void LogExtensionActivity(

- content::BrowserContext* browser_context,

- bool is_incognito,

- const std::string& extension_id,

- const GURL& url,

- const std::string& api_call,

- scoped_ptr<base::DictionaryValue> details) override;

+ void ExtractExtraRequestDetails(net::URLRequest* request,

+ base::DictionaryValue* out) override;

+ bool OnGetMatchingListenersImplCheck(int tab_id,

+ int window_id,

+ net::URLRequest* request) override;

+ void LogExtensionActivity(content::BrowserContext* browser_context,

+ bool is_incognito,

+ const std::string& extension_id,

+ const GURL& url,

+ const std::string& api_call,

+ scoped_ptr<base::DictionaryValue> details) override;

};

#endif // CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_CHROME_EXTENSION_WEB_REQUEST_EVENT_ROUTER_DELEGATE_H_