chrome/browser/extensions/api/alarms/alarm_manager.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarm_manager.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc ('k') | chrome/browser/extensions/api/alarms/alarm_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/alarms/alarm_manager.h

diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.h b/chrome/browser/extensions/api/alarms/alarm_manager.h

index a0c9711c2f3f0a10c890500c5a0b4107d92bb271..8df88ca41f8a28f8bac7fe402fdf1711258bed93 100644

--- a/chrome/browser/extensions/api/alarms/alarm_manager.h

+++ b/chrome/browser/extensions/api/alarms/alarm_manager.h

@@ -68,7 +68,7 @@ class AlarmManager : public BrowserContextKeyedAPI,

};

explicit AlarmManager(content::BrowserContext* context);

- virtual ~AlarmManager();

+ ~AlarmManager() override;

// Override the default delegate. Callee assumes onwership. Used for testing.

void set_delegate(Delegate* delegate) { delegate_.reset(delegate); }

@@ -202,12 +202,11 @@ class AlarmManager : public BrowserContextKeyedAPI,

void RunWhenReady(const std::string& extension_id, const ReadyAction& action);

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,

- const Extension* extension) override;

- virtual void OnExtensionUninstalled(

- content::BrowserContext* browser_context,

- const Extension* extension,

- extensions::UninstallReason reason) override;

+ void OnExtensionLoaded(content::BrowserContext* browser_context,

+ const Extension* extension) override;

+ void OnExtensionUninstalled(content::BrowserContext* browser_context,

+ const Extension* extension,

+ extensions::UninstallReason reason) override;

// BrowserContextKeyedAPI implementation.

static const char* service_name() {