Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5327)

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_function.h
diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h
index 013ff128f71c77a3d4a5a30600dfc88e030e1927..4051ba18921a543af9073273df4b9b9c2f05070a 100644
--- a/chrome/browser/extensions/chrome_extension_function.h
+++ b/chrome/browser/extensions/chrome_extension_function.h
@@ -60,10 +60,10 @@ class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {
// Gets the "current" web contents if any. If there is no associated web
// contents then defaults to the foremost one.
- virtual content::WebContents* GetAssociatedWebContents() override;
+ content::WebContents* GetAssociatedWebContents() override;
protected:
- virtual ~ChromeUIThreadExtensionFunction();
+ ~ChromeUIThreadExtensionFunction() override;
};
// A chrome specific analog to AsyncExtensionFunction. This has access to a
@@ -78,7 +78,7 @@ class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
ChromeAsyncExtensionFunction();
protected:
- virtual ~ChromeAsyncExtensionFunction();
+ ~ChromeAsyncExtensionFunction() override;
// Deprecated, see AsyncExtensionFunction::RunAsync.
virtual bool RunAsync() = 0;
@@ -87,7 +87,7 @@ class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
static bool ValidationFailure(ChromeAsyncExtensionFunction* function);
private:
- virtual ResponseAction Run() override;
+ ResponseAction Run() override;
};
// A chrome specific analog to SyncExtensionFunction. This has access to a
@@ -102,7 +102,7 @@ class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
ChromeSyncExtensionFunction();
protected:
- virtual ~ChromeSyncExtensionFunction();
+ ~ChromeSyncExtensionFunction() override;
// Deprecated, see SyncExtensionFunction::RunSync.
virtual bool RunSync() = 0;
@@ -111,7 +111,7 @@ class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
static bool ValidationFailure(ChromeSyncExtensionFunction* function);
private:
- virtual ResponseAction Run() override;
+ ResponseAction Run() override;
};
#endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_

Powered by Google App Engine
This is Rietveld 408576698