chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/module/module.h ('k') | chrome/browser/extensions/api/networking_private/crypto_verify_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h

diff --git a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h b/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h

index d1e9d99016ce4b4350e8625e58287e6db8666b56..88af6a84c79208737385765177c7aeeb2822231d 100644

--- a/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h

+++ b/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.h

@@ -18,10 +18,10 @@ class MusicManagerPrivateGetDeviceIdFunction : public AsyncExtensionFunction {

MusicManagerPrivateGetDeviceIdFunction();

protected:

- virtual ~MusicManagerPrivateGetDeviceIdFunction();

+ ~MusicManagerPrivateGetDeviceIdFunction() override;

// ExtensionFunction:

- virtual bool RunAsync() override;

+ bool RunAsync() override;

void DeviceIdCallback(const std::string& device_id);

};