chrome/browser/extensions/api/system_memory/system_memory_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_memory/system_memory_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_indicator/system_indicator_manager_factory.h ('k') | chrome/browser/extensions/api/system_private/system_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_memory/system_memory_apitest.cc

diff --git a/chrome/browser/extensions/api/system_memory/system_memory_apitest.cc b/chrome/browser/extensions/api/system_memory/system_memory_apitest.cc

index 5d0af3ac495ae8e16c832e658b14bbd813f9926a..ee9b5b9b256918ea9c97d2c8ef8c560fcff8d6ef 100644

--- a/chrome/browser/extensions/api/system_memory/system_memory_apitest.cc

+++ b/chrome/browser/extensions/api/system_memory/system_memory_apitest.cc

@@ -14,13 +14,13 @@ class MockMemoryInfoProviderImpl : public MemoryInfoProvider {

public:

MockMemoryInfoProviderImpl() {}

- virtual bool QueryInfo() override {

+ bool QueryInfo() override {

info_.capacity = 4096;

info_.available_capacity = 1024;

return true;

}

private:

- virtual ~MockMemoryInfoProviderImpl() {}

+ ~MockMemoryInfoProviderImpl() override {}

};

class SystemMemoryApiTest: public ExtensionApiTest {

@@ -28,7 +28,7 @@ class SystemMemoryApiTest: public ExtensionApiTest {

SystemMemoryApiTest() {}

virtual ~SystemMemoryApiTest() {}

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

ExtensionApiTest::SetUpInProcessBrowserTestFixture();

message_loop_.reset(new base::MessageLoopForUI);

}