Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: chrome/browser/extensions/extension_assets_manager.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_apitest.h ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_assets_manager.cc
diff --git a/chrome/browser/extensions/extension_assets_manager.cc b/chrome/browser/extensions/extension_assets_manager.cc
index 6b74ede369745bdb7d2529342c19b49ec3b89e70..bdb862da21680f33b89ecb0833f5beaa70b56fc7 100644
--- a/chrome/browser/extensions/extension_assets_manager.cc
+++ b/chrome/browser/extensions/extension_assets_manager.cc
@@ -22,11 +22,11 @@ class ExtensionAssetsManagerImpl : public ExtensionAssetsManager {
}
// Override from ExtensionAssetsManager.
- virtual void InstallExtension(const Extension* extension,
- const base::FilePath& unpacked_extension_root,
- const base::FilePath& local_install_dir,
- Profile* profile,
- InstallExtensionCallback callback) override {
+ void InstallExtension(const Extension* extension,
+ const base::FilePath& unpacked_extension_root,
+ const base::FilePath& local_install_dir,
+ Profile* profile,
+ InstallExtensionCallback callback) override {
callback.Run(file_util::InstallExtension(
unpacked_extension_root,
extension->id(),
@@ -34,11 +34,10 @@ class ExtensionAssetsManagerImpl : public ExtensionAssetsManager {
local_install_dir));
}
- virtual void UninstallExtension(
- const std::string& id,
- Profile* profile,
- const base::FilePath& local_install_dir,
- const base::FilePath& extension_root) override {
+ void UninstallExtension(const std::string& id,
+ Profile* profile,
+ const base::FilePath& local_install_dir,
+ const base::FilePath& extension_root) override {
file_util::UninstallExtension(local_install_dir, id);
}
@@ -46,7 +45,7 @@ class ExtensionAssetsManagerImpl : public ExtensionAssetsManager {
friend struct DefaultSingletonTraits<ExtensionAssetsManagerImpl>;
ExtensionAssetsManagerImpl() {}
- virtual ~ExtensionAssetsManagerImpl() {}
+ ~ExtensionAssetsManagerImpl() override {}
DISALLOW_COPY_AND_ASSIGN(ExtensionAssetsManagerImpl);
};
« no previous file with comments | « chrome/browser/extensions/extension_apitest.h ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698