chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_apitest.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

diff --git a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

index 4c5db03204238a26f244506888de372b74eb01ed..e0dad1ca3f146b267e0c97ede94a21754f70dacd 100644

--- a/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

+++ b/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h

@@ -23,7 +23,7 @@ class SettingsOverridesAPI : public BrowserContextKeyedAPI,

public ExtensionRegistryObserver {

public:

explicit SettingsOverridesAPI(content::BrowserContext* context);

- virtual ~SettingsOverridesAPI();

+ ~SettingsOverridesAPI() override;

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<SettingsOverridesAPI>*

@@ -42,15 +42,14 @@ class SettingsOverridesAPI : public BrowserContextKeyedAPI,

const std::string& pref_key);

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionLoaded(content::BrowserContext* browser_context,

- const Extension* extension) override;

- virtual void OnExtensionUnloaded(

- content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason) override;

+ void OnExtensionLoaded(content::BrowserContext* browser_context,

+ const Extension* extension) override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

// KeyedService implementation.

- virtual void Shutdown() override;

+ void Shutdown() override;

void OnTemplateURLsLoaded();