Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2787)

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
index 7fe564e4bfde192e56985bb45c96f8dc3aa9e667..40e184bbf3b64d5776b523af8abb94ca9feb063d 100644
--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
@@ -69,10 +69,10 @@ class AutomationWebContentsObserver
: public content::WebContentsObserver,
public content::WebContentsUserData<AutomationWebContentsObserver> {
public:
- virtual ~AutomationWebContentsObserver() {}
+ ~AutomationWebContentsObserver() override {}
// content::WebContentsObserver overrides.
- virtual void AccessibilityEventReceived(
+ void AccessibilityEventReceived(
const std::vector<content::AXEventNotificationDetails>& details)
override {
automation_util::DispatchAccessibilityEventsToAutomation(
@@ -80,7 +80,7 @@ class AutomationWebContentsObserver
web_contents()->GetContainerBounds().OffsetFromOrigin());
}
- virtual void RenderFrameDeleted(
+ void RenderFrameDeleted(
content::RenderFrameHost* render_frame_host) override {
automation_util::DispatchTreeDestroyedEventToAutomation(
render_frame_host->GetProcess()->GetID(),
@@ -110,19 +110,15 @@ class RenderFrameHostActionAdapter : public AutomationActionAdapter {
virtual ~RenderFrameHostActionAdapter() {}
// AutomationActionAdapter implementation.
- virtual void DoDefault(int32 id) override {
- rfh_->AccessibilityDoDefaultAction(id);
- }
+ void DoDefault(int32 id) override { rfh_->AccessibilityDoDefaultAction(id); }
- virtual void Focus(int32 id) override {
- rfh_->AccessibilitySetFocus(id);
- }
+ void Focus(int32 id) override { rfh_->AccessibilitySetFocus(id); }
- virtual void MakeVisible(int32 id) override {
+ void MakeVisible(int32 id) override {
rfh_->AccessibilityScrollToMakeVisible(id, gfx::Rect());
}
- virtual void SetSelection(int32 id, int32 start, int32 end) override {
+ void SetSelection(int32 id, int32 start, int32 end) override {
rfh_->AccessibilitySetTextSelection(id, start, end);
}

Powered by Google App Engine
This is Rietveld 408576698