chrome/browser/extensions/api/content_settings/content_settings_service.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_service.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_apitest.cc ('k') | chrome/browser/extensions/api/context_menus/context_menus_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_service.h

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_service.h b/chrome/browser/extensions/api/content_settings/content_settings_service.h

index 4534dfc06d35a12455d2e2152591dce7cd420727..2b7b3e39aed5cd9a903cc377a2deb996fa0f3740 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_service.h

+++ b/chrome/browser/extensions/api/content_settings/content_settings_service.h

@@ -20,7 +20,7 @@ class ContentSettingsService : public BrowserContextKeyedAPI,

public ExtensionPrefsObserver {

public:

explicit ContentSettingsService(content::BrowserContext* context);

- virtual ~ContentSettingsService();

+ ~ContentSettingsService() override;

scoped_refptr<ContentSettingsStore> content_settings_store() const {

return content_settings_store_;

@@ -34,15 +34,14 @@ class ContentSettingsService : public BrowserContextKeyedAPI,

GetFactoryInstance();

// ExtensionPrefsObserver implementation.

- virtual void OnExtensionRegistered(const std::string& extension_id,

- const base::Time& install_time,

- bool is_enabled) override;

- virtual void OnExtensionPrefsLoaded(const std::string& extension_id,

- const ExtensionPrefs* prefs) override;

- virtual void OnExtensionPrefsDeleted(const std::string& extension_id)

- override;

- virtual void OnExtensionStateChanged(const std::string& extension_id,

- bool state) override;

+ void OnExtensionRegistered(const std::string& extension_id,

+ const base::Time& install_time,

+ bool is_enabled) override;

+ void OnExtensionPrefsLoaded(const std::string& extension_id,

+ const ExtensionPrefs* prefs) override;

+ void OnExtensionPrefsDeleted(const std::string& extension_id) override;

+ void OnExtensionStateChanged(const std::string& extension_id,

+ bool state) override;

private:

friend class BrowserContextKeyedAPIFactory<ContentSettingsService>;