Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6630)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.h ('k') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_event_router.h
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.h b/chrome/browser/extensions/api/tabs/tabs_event_router.h
index eaa25c049253975a9f3251a553d9d7511be06884..492607856d4a2981edcdc7358979056bc171ba28 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.h
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.h
@@ -33,49 +33,47 @@ class TabsEventRouter : public TabStripModelObserver,
public ZoomObserver {
public:
explicit TabsEventRouter(Profile* profile);
- virtual ~TabsEventRouter();
+ ~TabsEventRouter() override;
// chrome::BrowserListObserver
- virtual void OnBrowserAdded(Browser* browser) override;
- virtual void OnBrowserRemoved(Browser* browser) override;
- virtual void OnBrowserSetLastActive(Browser* browser) override;
+ void OnBrowserAdded(Browser* browser) override;
+ void OnBrowserRemoved(Browser* browser) override;
+ void OnBrowserSetLastActive(Browser* browser) override;
// TabStripModelObserver
- virtual void TabInsertedAt(content::WebContents* contents, int index,
- bool active) override;
- virtual void TabClosingAt(TabStripModel* tab_strip_model,
- content::WebContents* contents,
- int index) override;
- virtual void TabDetachedAt(content::WebContents* contents,
+ void TabInsertedAt(content::WebContents* contents,
+ int index,
+ bool active) override;
+ void TabClosingAt(TabStripModel* tab_strip_model,
+ content::WebContents* contents,
+ int index) override;
+ void TabDetachedAt(content::WebContents* contents, int index) override;
+ void ActiveTabChanged(content::WebContents* old_contents,
+ content::WebContents* new_contents,
+ int index,
+ int reason) override;
+ void TabSelectionChanged(TabStripModel* tab_strip_model,
+ const ui::ListSelectionModel& old_model) override;
+ void TabMoved(content::WebContents* contents,
+ int from_index,
+ int to_index) override;
+ void TabChangedAt(content::WebContents* contents,
+ int index,
+ TabChangeType change_type) override;
+ void TabReplacedAt(TabStripModel* tab_strip_model,
+ content::WebContents* old_contents,
+ content::WebContents* new_contents,
+ int index) override;
+ void TabPinnedStateChanged(content::WebContents* contents,
int index) override;
- virtual void ActiveTabChanged(content::WebContents* old_contents,
- content::WebContents* new_contents,
- int index,
- int reason) override;
- virtual void TabSelectionChanged(
- TabStripModel* tab_strip_model,
- const ui::ListSelectionModel& old_model) override;
- virtual void TabMoved(content::WebContents* contents,
- int from_index,
- int to_index) override;
- virtual void TabChangedAt(content::WebContents* contents,
- int index,
- TabChangeType change_type) override;
- virtual void TabReplacedAt(TabStripModel* tab_strip_model,
- content::WebContents* old_contents,
- content::WebContents* new_contents,
- int index) override;
- virtual void TabPinnedStateChanged(content::WebContents* contents,
- int index) override;
// content::NotificationObserver.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// ZoomObserver.
- virtual void OnZoomChanged(
- const ZoomController::ZoomChangedEventData& data) override;
+ void OnZoomChanged(const ZoomController::ZoomChangedEventData& data) override;
private:
// "Synthetic" event. Called from TabInsertedAt if new tab is detected.
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.h ('k') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698