Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6012)

Unified Diff: chrome/browser/extensions/api/location/location_manager.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/location/location_manager.cc
diff --git a/chrome/browser/extensions/api/location/location_manager.cc b/chrome/browser/extensions/api/location/location_manager.cc
index 3b5b9854177c7139db5fdeeb2976450c6b70c3f6..142470127f65b53ee8908fdc92493e37c294e7a4 100644
--- a/chrome/browser/extensions/api/location/location_manager.cc
+++ b/chrome/browser/extensions/api/location/location_manager.cc
@@ -57,8 +57,7 @@ class DistanceBasedUpdatePolicy : public UpdatePolicy {
{}
// UpdatePolicy Implementation
- virtual bool ShouldSendUpdate(const content::Geoposition& position) const
- override {
+ bool ShouldSendUpdate(const content::Geoposition& position) const override {
return !last_updated_position_.Validate() ||
Distance(position.latitude,
position.longitude,
@@ -67,13 +66,12 @@ class DistanceBasedUpdatePolicy : public UpdatePolicy {
distance_update_threshold_meters_;
}
- virtual void OnPositionReported(const content::Geoposition& position)
- override {
+ void OnPositionReported(const content::Geoposition& position) override {
last_updated_position_ = position;
}
private:
- virtual ~DistanceBasedUpdatePolicy() {}
+ ~DistanceBasedUpdatePolicy() override {}
// Calculates the distance between two latitude and longitude points.
static double Distance(const double latitude1,
@@ -117,17 +115,17 @@ class TimeBasedUpdatePolicy : public UpdatePolicy {
{}
// UpdatePolicy Implementation
- virtual bool ShouldSendUpdate(const content::Geoposition&) const override {
+ bool ShouldSendUpdate(const content::Geoposition&) const override {
return (base::Time::Now() - last_update_time_).InMilliseconds() >
time_between_updates_ms_;
}
- virtual void OnPositionReported(const content::Geoposition&) override {
+ void OnPositionReported(const content::Geoposition&) override {
last_update_time_ = base::Time::Now();
}
private:
- virtual ~TimeBasedUpdatePolicy() {}
+ ~TimeBasedUpdatePolicy() override {}
base::Time last_update_time_;
const double time_between_updates_ms_;
« no previous file with comments | « chrome/browser/extensions/api/location/location_manager.h ('k') | chrome/browser/extensions/api/management/management_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698