chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_display_private_api.h ('k') | chrome/browser/extensions/api/braille_display_private/mock_braille_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

index 20e7a1523ed6079a929b435e922204e030bcf3b4..f5d8e50ff79faa50b5ceb52c4f69647444d25a78 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

@@ -29,10 +29,10 @@ class BrailleDisplayPrivateAPI::DefaultEventDelegate

: public BrailleDisplayPrivateAPI::EventDelegate {

public:

DefaultEventDelegate(EventRouter::Observer* observer, Profile* profile);

- virtual ~DefaultEventDelegate();

+ ~DefaultEventDelegate() override;

- virtual void BroadcastEvent(scoped_ptr<Event> event) override;

- virtual bool HasListener() override;

+ void BroadcastEvent(scoped_ptr<Event> event) override;

+ bool HasListener() override;

private:

EventRouter::Observer* observer_;