chrome/browser/extensions/chrome_component_extension_resource_manager.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_component_extension_resource_manager.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_app_sorting_unittest.cc ('k') | chrome/browser/extensions/chrome_content_browser_client_extensions_part.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_component_extension_resource_manager.h

diff --git a/chrome/browser/extensions/chrome_component_extension_resource_manager.h b/chrome/browser/extensions/chrome_component_extension_resource_manager.h

index 1ddd6e4c6845ddd0c3c0c965c018344acb6a009f..be3571e5a91cbf07c8b352a73330a6d6ab50e0d9 100644

--- a/chrome/browser/extensions/chrome_component_extension_resource_manager.h

+++ b/chrome/browser/extensions/chrome_component_extension_resource_manager.h

@@ -19,13 +19,12 @@ class ChromeComponentExtensionResourceManager

: public ComponentExtensionResourceManager {

public:

ChromeComponentExtensionResourceManager();

- virtual ~ChromeComponentExtensionResourceManager();

+ ~ChromeComponentExtensionResourceManager() override;

// Overridden from ComponentExtensionResourceManager:

- virtual bool IsComponentExtensionResource(

- const base::FilePath& extension_path,

- const base::FilePath& resource_path,

- int* resource_id) override;

+ bool IsComponentExtensionResource(const base::FilePath& extension_path,

+ const base::FilePath& resource_path,

+ int* resource_id) override;

private:

void AddComponentResourceEntries(const GritResourceMap* entries, size_t size);