chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_event_router_factory.h ('k') | chrome/browser/extensions/api/networking_private/networking_private_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

index 11cdd708d23dc403ee7dd1d9eb3cc3af74fb7205..b774546004732cad8e20ad989f0e2f97b828a373 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_event_router_nonchromeos.cc

@@ -20,20 +20,20 @@ class NetworkingPrivateEventRouterImpl

NetworkingPrivateServiceClient::Observer {

public:

explicit NetworkingPrivateEventRouterImpl(Profile* profile);

- virtual ~NetworkingPrivateEventRouterImpl();

+ ~NetworkingPrivateEventRouterImpl() override;

protected:

// KeyedService overrides:

- virtual void Shutdown() override;

+ void Shutdown() override;

// EventRouter::Observer overrides:

- virtual void OnListenerAdded(const EventListenerInfo& details) override;

- virtual void OnListenerRemoved(const EventListenerInfo& details) override;

+ void OnListenerAdded(const EventListenerInfo& details) override;

+ void OnListenerRemoved(const EventListenerInfo& details) override;

// NetworkingPrivateServiceClient::Observer overrides:

- virtual void OnNetworksChangedEvent(

+ void OnNetworksChangedEvent(

const std::vector<std::string>& network_guids) override;

- virtual void OnNetworkListChangedEvent(

+ void OnNetworkListChangedEvent(

const std::vector<std::string>& network_guids) override;

private: