Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/policy_value_store.h
diff --git a/chrome/browser/extensions/api/storage/policy_value_store.h b/chrome/browser/extensions/api/storage/policy_value_store.h
index ee2c55a2b3312acfa3a2586704980418b2db997f..5a43de83a833b7157acdbc04fe623099e325f1f2 100644
--- a/chrome/browser/extensions/api/storage/policy_value_store.h
+++ b/chrome/browser/extensions/api/storage/policy_value_store.h
@@ -30,7 +30,7 @@ class PolicyValueStore : public ValueStore {
PolicyValueStore(const std::string& extension_id,
const scoped_refptr<SettingsObserverList>& observers,
scoped_ptr<ValueStore> delegate);
- virtual ~PolicyValueStore();
+ ~PolicyValueStore() override;
// Stores |policy| in the persistent database represented by the |delegate_|
// and notifies observers with the changes from the previous policy.
@@ -40,24 +40,23 @@ class PolicyValueStore : public ValueStore {
void DeleteStorage();
// ValueStore implementation:
- virtual size_t GetBytesInUse(const std::string& key) override;
- virtual size_t GetBytesInUse(const std::vector<std::string>& keys) override;
- virtual size_t GetBytesInUse() override;
- virtual ReadResult Get(const std::string& key) override;
- virtual ReadResult Get(const std::vector<std::string>& keys) override;
- virtual ReadResult Get() override;
- virtual WriteResult Set(
- WriteOptions options,
- const std::string& key,
- const base::Value& value) override;
- virtual WriteResult Set(
- WriteOptions options, const base::DictionaryValue& values) override;
- virtual WriteResult Remove(const std::string& key) override;
- virtual WriteResult Remove(const std::vector<std::string>& keys) override;
- virtual WriteResult Clear() override;
+ size_t GetBytesInUse(const std::string& key) override;
+ size_t GetBytesInUse(const std::vector<std::string>& keys) override;
+ size_t GetBytesInUse() override;
+ ReadResult Get(const std::string& key) override;
+ ReadResult Get(const std::vector<std::string>& keys) override;
+ ReadResult Get() override;
+ WriteResult Set(WriteOptions options,
+ const std::string& key,
+ const base::Value& value) override;
+ WriteResult Set(WriteOptions options,
+ const base::DictionaryValue& values) override;
+ WriteResult Remove(const std::string& key) override;
+ WriteResult Remove(const std::vector<std::string>& keys) override;
+ WriteResult Clear() override;
// Hopefully, as a Read-Only database, there is no reason to use these.
- virtual bool Restore() override;
- virtual bool RestoreKey(const std::string& key) override;
+ bool Restore() override;
+ bool RestoreKey(const std::string& key) override;
// For unit tests.
ValueStore* delegate() { return delegate_.get(); }

Powered by Google App Engine
This is Rietveld 408576698