Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/error_console/error_console_browsertest.cc
diff --git a/chrome/browser/extensions/error_console/error_console_browsertest.cc b/chrome/browser/extensions/error_console/error_console_browsertest.cc
index 1d9e96a5c230789b738f617288adfa32e3de15af..e7857a2eb4b83e384432e5528bf545e586515657 100644
--- a/chrome/browser/extensions/error_console/error_console_browsertest.cc
+++ b/chrome/browser/extensions/error_console/error_console_browsertest.cc
@@ -154,7 +154,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
}
// ErrorConsole::Observer implementation.
- virtual void OnErrorAdded(const ExtensionError* error) override {
+ void OnErrorAdded(const ExtensionError* error) override {
++errors_observed_;
if (errors_observed_ >= errors_expected_) {
if (waiting_)
@@ -162,9 +162,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
}
}
- virtual void OnErrorConsoleDestroyed() override {
- error_console_ = NULL;
- }
+ void OnErrorConsoleDestroyed() override { error_console_ = NULL; }
// Spin until the appropriate number of errors have been observed.
void WaitForErrors() {
@@ -199,7 +197,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
ACTION_NONE
};
- virtual void SetUpInProcessBrowserTestFixture() override {
+ void SetUpInProcessBrowserTestFixture() override {
ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
// We need to enable the ErrorConsole FeatureSwitch in order to collect
@@ -209,7 +207,7 @@ class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
FeatureSwitch::OVERRIDE_ENABLED);
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ExtensionBrowserTest::SetUpOnMainThread();
// Errors are only kept if we have Developer Mode enabled.
« no previous file with comments | « chrome/browser/extensions/error_console/error_console.h ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698