chrome/browser/extensions/api/image_writer_private/operation_manager.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_manager.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h ('k') | chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_manager.h

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager.h b/chrome/browser/extensions/api/image_writer_private/operation_manager.h

index 95ebfeb0743cb5e8a552fc4e526f61a4f15118a9..cf2d92b856e3db6ae66b8890db593deccd63cce7 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_manager.h

+++ b/chrome/browser/extensions/api/image_writer_private/operation_manager.h

@@ -47,9 +47,9 @@ class OperationManager : public BrowserContextKeyedAPI,

typedef std::string ExtensionId;

explicit OperationManager(content::BrowserContext* context);

- virtual ~OperationManager();

+ ~OperationManager() override;

- virtual void Shutdown() override;

+ void Shutdown() override;

// Starts a WriteFromUrl operation.

void StartWriteFromUrl(const ExtensionId& extension_id,

@@ -97,15 +97,14 @@ class OperationManager : public BrowserContextKeyedAPI,

}

// NotificationObserver implementation.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionUnloaded(

- content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason) override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

Operation* GetOperation(const ExtensionId& extension_id);

void DeleteOperation(const ExtensionId& extension_id);