Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
diff --git a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
index a792ce4a2acc1a75c11f8f3615e112dbefa572c5..e35c396b0075404a78112f2dc1963b4d1548abda 100644
--- a/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
+++ b/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
@@ -70,36 +70,34 @@ class ChromeContentRulesRegistry : public ContentRulesRegistry,
// ChromeContentRulesRegistry implementation:
// Applies all content rules given an update (CSS match change or
// page navigation, for now) from the renderer.
- virtual void Apply(
- content::WebContents* contents,
- const std::vector<std::string>& matching_css_selectors) override;
+ void Apply(content::WebContents* contents,
+ const std::vector<std::string>& matching_css_selectors) override;
// Applies all content rules given that a tab was just navigated.
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
content::WebContents* tab,
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
// Implementation of RulesRegistry:
- virtual std::string AddRulesImpl(
+ std::string AddRulesImpl(
const std::string& extension_id,
- const std::vector<linked_ptr<RulesRegistry::Rule> >& rules) override;
- virtual std::string RemoveRulesImpl(
+ const std::vector<linked_ptr<RulesRegistry::Rule>>& rules) override;
+ std::string RemoveRulesImpl(
const std::string& extension_id,
const std::vector<std::string>& rule_identifiers) override;
- virtual std::string RemoveAllRulesImpl(
- const std::string& extension_id) override;
+ std::string RemoveAllRulesImpl(const std::string& extension_id) override;
// content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Returns true if this object retains no allocated data. Only for debugging.
bool IsEmpty() const;
protected:
- virtual ~ChromeContentRulesRegistry();
+ ~ChromeContentRulesRegistry() override;
// Virtual for testing:
virtual base::Time GetExtensionInstallationTime(

Powered by Google App Engine
This is Rietveld 408576698