Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4605)

Unified Diff: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
diff --git a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
index 1875eb7ff12937d40364a5c9741127037b53cf30..75fc81de5b4dc7e1d939eef2cdefd91720f2d0d7 100644
--- a/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
+++ b/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h
@@ -18,10 +18,10 @@ class ScreenlockPrivateGetLockedFunction : public ChromeAsyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("screenlockPrivate.getLocked",
SCREENLOCKPRIVATE_GETLOCKED)
ScreenlockPrivateGetLockedFunction();
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
- virtual ~ScreenlockPrivateGetLockedFunction();
+ ~ScreenlockPrivateGetLockedFunction() override;
DISALLOW_COPY_AND_ASSIGN(ScreenlockPrivateGetLockedFunction);
};
@@ -30,10 +30,10 @@ class ScreenlockPrivateSetLockedFunction : public ChromeAsyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("screenlockPrivate.setLocked",
SCREENLOCKPRIVATE_SETLOCKED)
ScreenlockPrivateSetLockedFunction();
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
- virtual ~ScreenlockPrivateSetLockedFunction();
+ ~ScreenlockPrivateSetLockedFunction() override;
DISALLOW_COPY_AND_ASSIGN(ScreenlockPrivateSetLockedFunction);
};
@@ -43,10 +43,10 @@ class ScreenlockPrivateAcceptAuthAttemptFunction
DECLARE_EXTENSION_FUNCTION("screenlockPrivate.acceptAuthAttempt",
SCREENLOCKPRIVATE_ACCEPTAUTHATTEMPT)
ScreenlockPrivateAcceptAuthAttemptFunction();
- virtual bool RunSync() override;
+ bool RunSync() override;
private:
- virtual ~ScreenlockPrivateAcceptAuthAttemptFunction();
+ ~ScreenlockPrivateAcceptAuthAttemptFunction() override;
DISALLOW_COPY_AND_ASSIGN(ScreenlockPrivateAcceptAuthAttemptFunction);
};
@@ -54,7 +54,7 @@ class ScreenlockPrivateEventRouter : public extensions::BrowserContextKeyedAPI,
public ScreenlockBridge::Observer {
public:
explicit ScreenlockPrivateEventRouter(content::BrowserContext* context);
- virtual ~ScreenlockPrivateEventRouter();
+ ~ScreenlockPrivateEventRouter() override;
bool OnAuthAttempted(ScreenlockBridge::LockHandler::AuthType auth_type,
const std::string& value);
@@ -63,12 +63,12 @@ class ScreenlockPrivateEventRouter : public extensions::BrowserContextKeyedAPI,
static extensions::BrowserContextKeyedAPIFactory<
ScreenlockPrivateEventRouter>*
GetFactoryInstance();
- virtual void Shutdown() override;
+ void Shutdown() override;
// ScreenlockBridge::Observer
- virtual void OnScreenDidLock() override;
- virtual void OnScreenDidUnlock() override;
- virtual void OnFocusedUserChanged(const std::string& user_id) override;
+ void OnScreenDidLock() override;
+ void OnScreenDidUnlock() override;
+ void OnFocusedUserChanged(const std::string& user_id) override;
private:
friend class extensions::BrowserContextKeyedAPIFactory<

Powered by Google App Engine
This is Rietveld 408576698