chrome/browser/extensions/zipfile_installer.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/zipfile_installer.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/window_open_interactive_apitest.cc ('k') | chrome/browser/extensions/zipfile_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/zipfile_installer.h

diff --git a/chrome/browser/extensions/zipfile_installer.h b/chrome/browser/extensions/zipfile_installer.h

index 0420a6bb8a150be9bfdb2a7aa248c527c7b2aa2b..7aa594c41f3ad8e20d55c35523e71b420e753754 100644

--- a/chrome/browser/extensions/zipfile_installer.h

+++ b/chrome/browser/extensions/zipfile_installer.h

@@ -35,11 +35,11 @@ class ZipFileInstaller : public content::UtilityProcessHostClient {

void set_be_noisy_on_failure(bool value) { be_noisy_on_failure_ = value; }

// UtilityProcessHostClient

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

private:

explicit ZipFileInstaller(ExtensionService* extension_service);

- virtual ~ZipFileInstaller();

+ ~ZipFileInstaller() override;

void PrepareTempDir();

void StartWorkOnIOThread(const base::FilePath& temp_dir);