chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/write_from_file_operation.h ('k') | chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h

diff --git a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h

index 0b7ac73df42b0b79d3d5a66390343bfdc4d34396..259af14fd007bf468ede4c9597e1e2b50a331322 100644

--- a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h

+++ b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h

@@ -28,10 +28,10 @@ class WriteFromUrlOperation : public Operation, public net::URLFetcherDelegate {

GURL url,

const std::string& hash,

const std::string& storage_unit_id);

- virtual void StartImpl() override;

+ void StartImpl() override;

protected:

- virtual ~WriteFromUrlOperation();

+ ~WriteFromUrlOperation() override;

// Sets the image_path to the correct location to download to.

void GetDownloadTarget(const base::Closure& continuation);

@@ -51,13 +51,13 @@ class WriteFromUrlOperation : public Operation, public net::URLFetcherDelegate {

void DestroyUrlFetcher();

// URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

- virtual void OnURLFetchDownloadProgress(const net::URLFetcher* source,

- int64 current,

- int64 total) override;

- virtual void OnURLFetchUploadProgress(const net::URLFetcher* source,

- int64 current,

- int64 total) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchDownloadProgress(const net::URLFetcher* source,

+ int64 current,

+ int64 total) override;

+ void OnURLFetchUploadProgress(const net::URLFetcher* source,

+ int64 current,

+ int64 total) override;

void VerifyDownloadCompare(const base::Closure& continuation,

const std::string& download_hash);