Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/extension_message_port.h
diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.h b/chrome/browser/extensions/api/messaging/extension_message_port.h
index a10c0317377e38dba109053c0ad9c18641dae6bf..f427e23da5f5fc827341b9c042c5b44c36506380 100644
--- a/chrome/browser/extensions/api/messaging/extension_message_port.h
+++ b/chrome/browser/extensions/api/messaging/extension_message_port.h
@@ -21,21 +21,19 @@ class ExtensionMessagePort : public MessageService::MessagePort {
ExtensionMessagePort(content::RenderProcessHost* process,
int routing_id,
const std::string& extension_id);
- virtual void DispatchOnConnect(
- int dest_port_id,
- const std::string& channel_name,
- const base::DictionaryValue& source_tab,
- const std::string& source_extension_id,
- const std::string& target_extension_id,
- const GURL& source_url,
- const std::string& tls_channel_id) override;
- virtual void DispatchOnDisconnect(int source_port_id,
- const std::string& error_message) override;
- virtual void DispatchOnMessage(const Message& message,
- int target_port_id) override;
- virtual void IncrementLazyKeepaliveCount() override;
- virtual void DecrementLazyKeepaliveCount() override;
- virtual content::RenderProcessHost* GetRenderProcessHost() override;
+ void DispatchOnConnect(int dest_port_id,
+ const std::string& channel_name,
+ const base::DictionaryValue& source_tab,
+ const std::string& source_extension_id,
+ const std::string& target_extension_id,
+ const GURL& source_url,
+ const std::string& tls_channel_id) override;
+ void DispatchOnDisconnect(int source_port_id,
+ const std::string& error_message) override;
+ void DispatchOnMessage(const Message& message, int target_port_id) override;
+ void IncrementLazyKeepaliveCount() override;
+ void DecrementLazyKeepaliveCount() override;
+ content::RenderProcessHost* GetRenderProcessHost() override;
private:
content::RenderProcessHost* process_;

Powered by Google App Engine
This is Rietveld 408576698