chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc ('k') | chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h

index a1ff2a2b6250747610fe88c0b89daff6753f0bf4..b76b5c4a24018a7da40b0807c38e33540db33f15 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.h

@@ -46,13 +46,13 @@ class DesktopCaptureChooseDesktopMediaFunction

void Cancel();

private:

- virtual ~DesktopCaptureChooseDesktopMediaFunction();

+ ~DesktopCaptureChooseDesktopMediaFunction() override;

// ExtensionFunction overrides.

- virtual bool RunAsync() override;

+ bool RunAsync() override;

// content::WebContentsObserver overrides.

- virtual void WebContentsDestroyed() override;

+ void WebContentsDestroyed() override;

void OnPickerDialogResults(content::DesktopMediaID source);

@@ -73,10 +73,10 @@ class DesktopCaptureCancelChooseDesktopMediaFunction

DesktopCaptureCancelChooseDesktopMediaFunction();

private:

- virtual ~DesktopCaptureCancelChooseDesktopMediaFunction();

+ ~DesktopCaptureCancelChooseDesktopMediaFunction() override;

// ExtensionFunction overrides.

- virtual bool RunSync() override;

+ bool RunSync() override;

};

class DesktopCaptureRequestsRegistry {