Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/extensions/api/gcm/gcm_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/gcm/gcm_api.h
diff --git a/chrome/browser/extensions/api/gcm/gcm_api.h b/chrome/browser/extensions/api/gcm/gcm_api.h
index 01a21ccf92491dd2a0399dec5b511d3a0cd41626..b6b33d2b1c6d621b392032d6fdc8f51a8e75e7c1 100644
--- a/chrome/browser/extensions/api/gcm/gcm_api.h
+++ b/chrome/browser/extensions/api/gcm/gcm_api.h
@@ -23,10 +23,10 @@ class GcmApiFunction : public AsyncExtensionFunction {
GcmApiFunction() {}
protected:
- virtual ~GcmApiFunction() {}
+ ~GcmApiFunction() override {}
// ExtensionFunction:
- virtual bool RunAsync() override final;
+ bool RunAsync() final;
// Actual implementation of specific functions.
virtual bool DoWork() = 0;
@@ -44,10 +44,10 @@ class GcmRegisterFunction : public GcmApiFunction {
GcmRegisterFunction();
protected:
- virtual ~GcmRegisterFunction();
+ ~GcmRegisterFunction() override;
// Register function implementation.
- virtual bool DoWork() override final;
+ bool DoWork() final;
private:
void CompleteFunctionWithResult(const std::string& registration_id,
@@ -61,10 +61,10 @@ class GcmUnregisterFunction : public GcmApiFunction {
GcmUnregisterFunction();
protected:
- virtual ~GcmUnregisterFunction();
+ ~GcmUnregisterFunction() override;
// Register function implementation.
- virtual bool DoWork() override final;
+ bool DoWork() final;
private:
void CompleteFunctionWithResult(gcm::GCMClient::Result result);
@@ -77,10 +77,10 @@ class GcmSendFunction : public GcmApiFunction {
GcmSendFunction();
protected:
- virtual ~GcmSendFunction();
+ ~GcmSendFunction() override;
// Send function implementation.
- virtual bool DoWork() override final;
+ bool DoWork() final;
private:
void CompleteFunctionWithResult(const std::string& message_id,
« no previous file with comments | « chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc ('k') | chrome/browser/extensions/api/gcm/gcm_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698