chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc ('k') | chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index ee939aab0bc391f81994533c5dc64421566c7ce4..ef0339882496f5001a3e4d67baa03edb97745d73 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -46,12 +46,12 @@ class SocketsTcpServerApiTest : public ExtensionApiTest {

new extensions::MockHostResolverCreator()) {

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting(

resolver_creator_->CreateMockHostResolver());

}

- virtual void TearDownOnMainThread() override {

+ void TearDownOnMainThread() override {

extensions::HostResolverWrapper::GetInstance()->

SetHostResolverForTesting(NULL);

resolver_creator_->DeleteMockHostResolver();