chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmarks_api.h ('k') | chrome/browser/extensions/api/braille_display_private/braille_display_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc b/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

index 6ba977df714f3b0ae5f0e8dd7777f7fadc17104e..ba394d0472e737e55b5ce4ce503711b353b192ed 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc

@@ -17,14 +17,14 @@ namespace braille_display_private {

class BrailleControllerImpl : public BrailleController {

public:

static BrailleControllerImpl* GetInstance();

- virtual scoped_ptr<DisplayState> GetDisplayState() override;

- virtual void WriteDots(const std::string& cells) override;

- virtual void AddObserver(BrailleObserver* observer) override;

- virtual void RemoveObserver(BrailleObserver* observer) override;

+ scoped_ptr<DisplayState> GetDisplayState() override;

+ void WriteDots(const std::string& cells) override;

+ void AddObserver(BrailleObserver* observer) override;

+ void RemoveObserver(BrailleObserver* observer) override;

private:

BrailleControllerImpl();

- virtual ~BrailleControllerImpl();

+ ~BrailleControllerImpl() override;

friend struct DefaultSingletonTraits<BrailleControllerImpl>;

DISALLOW_COPY_AND_ASSIGN(BrailleControllerImpl);

};