chrome/browser/extensions/active_tab_permission_granter.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_script_controller_browsertest.cc ('k') | chrome/browser/extensions/activity_log/activity_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_tab_permission_granter.h

diff --git a/chrome/browser/extensions/active_tab_permission_granter.h b/chrome/browser/extensions/active_tab_permission_granter.h

index 68b31f754af7b29009a87102c020b79da29049cd..498c6e82c5631f51db4ce5534e8ac3745e344db8 100644

--- a/chrome/browser/extensions/active_tab_permission_granter.h

+++ b/chrome/browser/extensions/active_tab_permission_granter.h

@@ -34,7 +34,7 @@ class ActiveTabPermissionGranter

ActiveTabPermissionGranter(content::WebContents* web_contents,

int tab_id,

Profile* profile);

- virtual ~ActiveTabPermissionGranter();

+ ~ActiveTabPermissionGranter() override;

// If |extension| has the activeTab or tabCapture permission, grants

// tab-specific permissions to it until the next page navigation or refresh.

@@ -42,16 +42,15 @@ class ActiveTabPermissionGranter

private:

// content::WebContentsObserver implementation.

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- virtual void WebContentsDestroyed() override;

+ void WebContentsDestroyed() override;

// extensions::ExtensionRegistryObserver implementation.

- virtual void OnExtensionUnloaded(content::BrowserContext* browser_context,

- const Extension* extension,

- UnloadedExtensionInfo::Reason reason)

- override;

+ void OnExtensionUnloaded(content::BrowserContext* browser_context,

+ const Extension* extension,

+ UnloadedExtensionInfo::Reason reason) override;

// Clears any tab-specific permissions for all extensions on |tab_id_| and

// notifies renderers.