chrome/browser/extensions/api/dial/dial_api_factory.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_api_factory.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/dial/dial_api_factory.h

diff --git a/chrome/browser/extensions/api/dial/dial_api_factory.h b/chrome/browser/extensions/api/dial/dial_api_factory.h

index 7cf6dab11c81f1a3642143f298d986701ac3a34a..9bfc05d45f3b61527b730746138696fe301356c6 100644

--- a/chrome/browser/extensions/api/dial/dial_api_factory.h

+++ b/chrome/browser/extensions/api/dial/dial_api_factory.h

@@ -23,13 +23,13 @@ class DialAPIFactory : public RefcountedBrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<DialAPIFactory>;

DialAPIFactory();

- virtual ~DialAPIFactory();

+ ~DialAPIFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(

+ scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

- virtual bool ServiceIsCreatedWithBrowserContext() const override;

- virtual bool ServiceIsNULLWhileTesting() const override;

+ bool ServiceIsCreatedWithBrowserContext() const override;

+ bool ServiceIsNULLWhileTesting() const override;

DISALLOW_COPY_AND_ASSIGN(DialAPIFactory);

};

« no previous file with comments | « chrome/browser/extensions/api/dial/dial_api.h ('k') | chrome/browser/extensions/api/dial/dial_apitest.cc » ('j') | no next file with comments »