Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4548)

Unified Diff: chrome/browser/extensions/api/input/input.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input/input.h
diff --git a/chrome/browser/extensions/api/input/input.h b/chrome/browser/extensions/api/input/input.h
index 9cf8888fb1481702e4242e14851fa33a2e337e58..f9836f50c8a97a2507a52f9100b239b7d0e3c531 100644
--- a/chrome/browser/extensions/api/input/input.h
+++ b/chrome/browser/extensions/api/input/input.h
@@ -21,10 +21,10 @@ class VirtualKeyboardPrivateInsertTextFunction : public SyncExtensionFunction {
VIRTUALKEYBOARDPRIVATE_INSERTTEXT);
protected:
- virtual ~VirtualKeyboardPrivateInsertTextFunction() {}
+ ~VirtualKeyboardPrivateInsertTextFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateMoveCursorFunction : public SyncExtensionFunction {
@@ -33,10 +33,10 @@ class VirtualKeyboardPrivateMoveCursorFunction : public SyncExtensionFunction {
VIRTUALKEYBOARDPRIVATE_MOVECURSOR);
protected:
- virtual ~VirtualKeyboardPrivateMoveCursorFunction() {}
+ ~VirtualKeyboardPrivateMoveCursorFunction() override {}
// ExtensionFunction.
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateSendKeyEventFunction
@@ -47,10 +47,10 @@ class VirtualKeyboardPrivateSendKeyEventFunction
VIRTUALKEYBOARDPRIVATE_SENDKEYEVENT);
protected:
- virtual ~VirtualKeyboardPrivateSendKeyEventFunction() {}
+ ~VirtualKeyboardPrivateSendKeyEventFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateHideKeyboardFunction
@@ -61,10 +61,10 @@ class VirtualKeyboardPrivateHideKeyboardFunction
VIRTUALKEYBOARDPRIVATE_HIDEKEYBOARD);
protected:
- virtual ~VirtualKeyboardPrivateHideKeyboardFunction() {}
+ ~VirtualKeyboardPrivateHideKeyboardFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateLockKeyboardFunction
@@ -75,10 +75,10 @@ class VirtualKeyboardPrivateLockKeyboardFunction
VIRTUALKEYBOARDPRIVATE_LOCKKEYBOARD);
protected:
- virtual ~VirtualKeyboardPrivateLockKeyboardFunction() {}
+ ~VirtualKeyboardPrivateLockKeyboardFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateKeyboardLoadedFunction
@@ -89,10 +89,10 @@ class VirtualKeyboardPrivateKeyboardLoadedFunction
VIRTUALKEYBOARDPRIVATE_KEYBOARDLOADED);
protected:
- virtual ~VirtualKeyboardPrivateKeyboardLoadedFunction() {}
+ ~VirtualKeyboardPrivateKeyboardLoadedFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateGetKeyboardConfigFunction
@@ -103,10 +103,10 @@ class VirtualKeyboardPrivateGetKeyboardConfigFunction
VIRTUALKEYBOARDPRIVATE_GETKEYBOARDCONFIG);
protected:
- virtual ~VirtualKeyboardPrivateGetKeyboardConfigFunction() {}
+ ~VirtualKeyboardPrivateGetKeyboardConfigFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class VirtualKeyboardPrivateOpenSettingsFunction
@@ -116,17 +116,17 @@ class VirtualKeyboardPrivateOpenSettingsFunction
VIRTUALKEYBOARDPRIVATE_OPENSETTINGS);
protected:
- virtual ~VirtualKeyboardPrivateOpenSettingsFunction() {}
+ ~VirtualKeyboardPrivateOpenSettingsFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
class InputAPI : public BrowserContextKeyedAPI {
public:
explicit InputAPI(content::BrowserContext* context);
- virtual ~InputAPI();
+ ~InputAPI() override;
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<InputAPI>* GetFactoryInstance();

Powered by Google App Engine
This is Rietveld 408576698