chrome/browser/extensions/extension_action_icon_factory.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_icon_factory.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action.cc ('k') | chrome/browser/extensions/extension_action_icon_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_icon_factory.h

diff --git a/chrome/browser/extensions/extension_action_icon_factory.h b/chrome/browser/extensions/extension_action_icon_factory.h

index 6869e8ec5795126f8c147b1e7aab37c198f1a0b2..3860216e8c5ae742839f208443487a309ab97ac1 100644

--- a/chrome/browser/extensions/extension_action_icon_factory.h

+++ b/chrome/browser/extensions/extension_action_icon_factory.h

@@ -35,11 +35,10 @@ class ExtensionActionIconFactory : public extensions::IconImage::Observer {

const extensions::Extension* extension,

const ExtensionAction* action,

Observer* observer);

- virtual ~ExtensionActionIconFactory();

+ ~ExtensionActionIconFactory() override;

// extensions::IconImage override.

- virtual void OnExtensionIconImageChanged(

- extensions::IconImage* image) override;

+ void OnExtensionIconImageChanged(extensions::IconImage* image) override;

// Gets the extension action icon for the tab.

// If there is an icon set using |SetIcon|, that icon is returned.