Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: chrome/browser/extensions/api/identity/gaia_web_auth_flow.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/gaia_web_auth_flow.h
diff --git a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.h b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.h
index 364acd64fddc777c677db02a2404259c39f1361f..58e18f9a913dfea8d93f1dd156313884ed33bfa9 100644
--- a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.h
+++ b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.h
@@ -64,19 +64,19 @@ class GaiaWebAuthFlow : public UbertokenConsumer, public WebAuthFlow::Delegate {
const ExtensionTokenKey* token_key,
const std::string& oauth2_client_id,
const std::string& locale);
- virtual ~GaiaWebAuthFlow();
+ ~GaiaWebAuthFlow() override;
// Starts the flow by fetching an ubertoken. Can override for testing.
virtual void Start();
// UbertokenConsumer implementation:
- virtual void OnUbertokenSuccess(const std::string& token) override;
- virtual void OnUbertokenFailure(const GoogleServiceAuthError& error) override;
+ void OnUbertokenSuccess(const std::string& token) override;
+ void OnUbertokenFailure(const GoogleServiceAuthError& error) override;
// WebAuthFlow::Delegate implementation.
- virtual void OnAuthFlowFailure(WebAuthFlow::Failure failure) override;
- virtual void OnAuthFlowURLChange(const GURL& redirect_url) override;
- virtual void OnAuthFlowTitleChange(const std::string& title) override;
+ void OnAuthFlowFailure(WebAuthFlow::Failure failure) override;
+ void OnAuthFlowURLChange(const GURL& redirect_url) override;
+ void OnAuthFlowTitleChange(const std::string& title) override;
private:
// Creates a WebAuthFlow, which will navigate to |url|. Can override
« no previous file with comments | « chrome/browser/extensions/api/i18n/i18n_api.h ('k') | chrome/browser/extensions/api/identity/gaia_web_auth_flow_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698