Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6272)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.h
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.h b/chrome/browser/extensions/api/permissions/permissions_api.h
index d0eaa5203c36ae5cfa362cb46272e0b0010963fd..fa6431f27716069428aebe31cc46038917b93853 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.h
+++ b/chrome/browser/extensions/api/permissions/permissions_api.h
@@ -20,10 +20,10 @@ class PermissionsContainsFunction : public ChromeSyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("permissions.contains", PERMISSIONS_CONTAINS)
protected:
- virtual ~PermissionsContainsFunction() {}
+ ~PermissionsContainsFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
// chrome.permissions.getAll
@@ -32,10 +32,10 @@ class PermissionsGetAllFunction : public ChromeSyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("permissions.getAll", PERMISSIONS_GETALL)
protected:
- virtual ~PermissionsGetAllFunction() {}
+ ~PermissionsGetAllFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
// chrome.permissions.remove
@@ -44,10 +44,10 @@ class PermissionsRemoveFunction : public ChromeSyncExtensionFunction {
DECLARE_EXTENSION_FUNCTION("permissions.remove", PERMISSIONS_REMOVE)
protected:
- virtual ~PermissionsRemoveFunction() {}
+ ~PermissionsRemoveFunction() override {}
// ExtensionFunction:
- virtual bool RunSync() override;
+ bool RunSync() override;
};
// chrome.permissions.request
@@ -63,14 +63,14 @@ class PermissionsRequestFunction : public ChromeAsyncExtensionFunction,
static void SetIgnoreUserGestureForTests(bool ignore);
// ExtensionInstallPrompt::Delegate:
- virtual void InstallUIProceed() override;
- virtual void InstallUIAbort(bool user_initiated) override;
+ void InstallUIProceed() override;
+ void InstallUIAbort(bool user_initiated) override;
protected:
- virtual ~PermissionsRequestFunction();
+ ~PermissionsRequestFunction() override;
// ExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
scoped_ptr<ExtensionInstallPrompt> install_ui_;

Powered by Google App Engine
This is Rietveld 408576698