chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.h ('k') | chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc b/chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc

index 6798c63dca21ce7ea22821db2b919c7efe754701..1d8e23e1d98aadbe0626c04293b01cc492a12b9e 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_prefs_unittest.cc

@@ -16,7 +16,7 @@ namespace extensions {

// Tests force hiding browser actions.

class ExtensionPrefsHidingBrowserActions : public ExtensionPrefsTest {

public:

- virtual void Initialize() override {

+ void Initialize() override {

// Install 5 extensions.

for (int i = 0; i < 5; i++) {

std::string name = "test" + base::IntToString(i);

@@ -35,7 +35,7 @@ class ExtensionPrefsHidingBrowserActions : public ExtensionPrefsTest {

prefs(), extensions_[1]->id(), true);

}

- virtual void Verify() override {

+ void Verify() override {

// Make sure the one we hid is hidden.

EXPECT_FALSE(ExtensionActionAPI::GetBrowserActionVisibility(

prefs(), extensions_[0]->id()));