Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
index 0ea0233fb0597eae9339f9fd45595c82c6bde17c..f83858a094ade26f8d98fd01c97c1154c2c901fc 100644
--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
@@ -45,7 +45,7 @@ class TabCaptureRegistry::LiveRequest : public content::WebContentsObserver {
DCHECK(registry_);
}
- virtual ~LiveRequest() {}
+ ~LiveRequest() override {}
// Accessors.
const std::string& extension_id() const {
@@ -96,25 +96,25 @@ class TabCaptureRegistry::LiveRequest : public content::WebContentsObserver {
}
protected:
- virtual void DidShowFullscreenWidget(int routing_id) override {
+ void DidShowFullscreenWidget(int routing_id) override {
is_fullscreened_ = true;
if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
registry_->DispatchStatusChangeEvent(this);
}
- virtual void DidDestroyFullscreenWidget(int routing_id) override {
+ void DidDestroyFullscreenWidget(int routing_id) override {
is_fullscreened_ = false;
if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
registry_->DispatchStatusChangeEvent(this);
}
- virtual void DidToggleFullscreenModeForTab(bool entered_fullscreen) override {
+ void DidToggleFullscreenModeForTab(bool entered_fullscreen) override {
is_fullscreened_ = entered_fullscreen;
if (capture_state_ == tab_capture::TAB_CAPTURE_STATE_ACTIVE)
registry_->DispatchStatusChangeEvent(this);
}
- virtual void WebContentsDestroyed() override {
+ void WebContentsDestroyed() override {
registry_->KillRequest(this); // Deletes |this|.
}
« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_registry.h ('k') | chrome/browser/extensions/api/tabs/tabs_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698