Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h
diff --git a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h
index 70dfad0ee9eff43d441b5c83c3e2ad24382a18d3..823ea614da6fc96af08bad325fbe816eda478a6e 100644
--- a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h
+++ b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h
@@ -23,10 +23,10 @@ class ChromeWebViewInternalContextMenusCreateFunction
ChromeWebViewInternalContextMenusCreateFunction() {}
protected:
- virtual ~ChromeWebViewInternalContextMenusCreateFunction() {}
+ ~ChromeWebViewInternalContextMenusCreateFunction() override {}
// ExtensionFunction implementation.
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalContextMenusCreateFunction);
@@ -40,10 +40,10 @@ class ChromeWebViewInternalContextMenusUpdateFunction
ChromeWebViewInternalContextMenusUpdateFunction() {}
protected:
- virtual ~ChromeWebViewInternalContextMenusUpdateFunction() {}
+ ~ChromeWebViewInternalContextMenusUpdateFunction() override {}
// ExtensionFunction implementation.
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalContextMenusUpdateFunction);
@@ -57,10 +57,10 @@ class ChromeWebViewInternalContextMenusRemoveFunction
ChromeWebViewInternalContextMenusRemoveFunction() {}
protected:
- virtual ~ChromeWebViewInternalContextMenusRemoveFunction() {}
+ ~ChromeWebViewInternalContextMenusRemoveFunction() override {}
// ExtensionFunction implementation.
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalContextMenusRemoveFunction);
@@ -74,10 +74,10 @@ class ChromeWebViewInternalContextMenusRemoveAllFunction
ChromeWebViewInternalContextMenusRemoveAllFunction() {}
protected:
- virtual ~ChromeWebViewInternalContextMenusRemoveAllFunction() {}
+ ~ChromeWebViewInternalContextMenusRemoveAllFunction() override {}
// ExtensionFunction implementation.
- virtual bool RunAsync() override;
+ bool RunAsync() override;
private:
DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalContextMenusRemoveAllFunction);
@@ -92,11 +92,11 @@ class ChromeWebViewInternalShowContextMenuFunction
ChromeWebViewInternalShowContextMenuFunction();
protected:
- virtual ~ChromeWebViewInternalShowContextMenuFunction();
+ ~ChromeWebViewInternalShowContextMenuFunction() override;
private:
// WebViewInternalExtensionFunction implementation.
- virtual bool RunAsyncSafe(WebViewGuest* guest) override;
+ bool RunAsyncSafe(WebViewGuest* guest) override;
DISALLOW_COPY_AND_ASSIGN(ChromeWebViewInternalShowContextMenuFunction);
};

Powered by Google App Engine
This is Rietveld 408576698